Don't propagate parent's context for the background replay #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mateusz-sekara
changed the title
dimkouv
approved these changes
Jul 24, 2024
0xnogo
approved these changes
Jul 24, 2024
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Solution It adds the missing part to this PR #1201 We can't pass the foreground routine context to the task run in the background and could take minutes or hours to finish. Instead of that, we create a background context and expose cancelFn. This is exactly how it used to work before introducing loopp layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
It adds the missing part to this PR #1201
We can't pass the foreground routine context to the task run in the background and could take minutes or hours to finish. Instead of that, we create a background context and expose cancelFn. This is exactly how it used to work before introducing loopp layer